 Li Liu
|
2b0e1ba711
|
refactor: comprehensive codebase improvements across 7 phases
Phase A - Quick fixes:
- Remove debug logging that leaked prompt content (qwen-code)
- Fix orchestrator session leak with try/finally cleanup
- CJK-aware token estimation for better accuracy
- Issue parser validation (line > 0, endLine >= line, non-empty fields)
- Improved similarity matching with stop words filtering and description weight
Phase B - Medium fixes:
- Add retry utility with exponential backoff for API providers
- Config validation at load time (required fields, empty API key warnings)
- GitHub PR comment deduplication (skip already-posted comments)
- Ctrl+C graceful exit for interactive comment review
Phase C - Structured logging:
- Logger class with debug/info/warn/error levels (MAGPIE_LOG_LEVEL env var)
Phase D - Type safety:
- Replace `any` types with proper types across discuss.ts, review.ts,
issue-parser.ts, commenter.ts, repo-orchestrator.ts, history-collector.ts
Phase E - Session helper extraction:
- CliSessionHelper class shared by 4 CLI providers, reducing duplication
Phase F - Split review.ts (1991 → 6 files):
- review.ts (command + action), interactive.ts, repo-review.ts,
session-cmds.ts, utils.ts, types.ts
Phase G - Tests:
- 6 new test files (retry, logger, session-helper, issue-parser-enhanced,
loader-validation, orchestrator-session)
- Fix pre-existing test failures (commenter, anthropic)
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
2026-02-25 22:46:46 +08:00 |
|